Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build scan badge readability with long tasks #200

Merged
merged 3 commits into from Apr 25, 2024
Merged

Improve build scan badge readability with long tasks #200

merged 3 commits into from Apr 25, 2024

Conversation

gabrielfeo
Copy link
Contributor

@gabrielfeo gabrielfeo commented Apr 25, 2024 •
edited

Improve readability of build scan when requested tasks is very long, as agreed in #175. HTML diff for each case of job summary is clearer in cd62d9c.

  • Ensure a minimum size for the badge, at least the size of "Build scan®", by preventing a line break with  
  • Reduce the size of the badge by tweaking the inner text

Also fix a typo in the build shell script.

@gabrielfeo
Fix typo in build shell script
ef36f81 
Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
@gabrielfeo
Add tests on current job-summary behavior
a54fb6a 
Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
@gabrielfeo
Improve job summary readability with long tasks
cd62d9c 
Change tests for nbsp and concise badge

Make tests pass

Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
@gabrielfeo
Copy link
Contributor Author

gabrielfeo commented Apr 25, 2024 •
edited

Here's how tables render in the end (just the HTML from the unit tests):

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root help 8.0 ✅ Build Scan published
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root help 8.0 ❌ Build Scan published
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root help 8.0 ✅ Build Scan not published
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root help 8.0 ✅ Build Scan publish failed
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root help 8.0 ✅ Build Scan published
root help 8.0 ❌ Build Scan published
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
root
check publishMyLongNamePluginPublicationToMavenCentral publ…
 8.0 ✅ Build Scan published

@bigdaz
Copy link
Member

bigdaz commented Apr 25, 2024

Thanks for the PR and for adding some test coverage. Much appreciated!

@bigdaz bigdaz linked an issue Apr 25, 2024 that may be closed by this pull request
Build scan badge is too small in Job Summary #175
Closed
@bigdaz bigdaz merged commit bce7dac into gradle:main Apr 25, 2024
59 checks passed
@bigdaz bigdaz added this to the v3.3.2 milestone Apr 25, 2024
@gabrielfeo gabrielfeo deleted the gaf/too-small-bs-badge branch April 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

Build scan badge is too small in Job Summary
2 participants
@gabrielfeo @bigdaz