Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency-submission fails to find workflow files when DEPENDENCY_GRAPH_REPORT_DIR is specified #188

Closed
bigdaz opened this issue Apr 18, 2024 · 0 comments · Fixed by #189
Assignees
Labels
bug Something isn't working in:dependency-submission
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented Apr 18, 2024

If set, the DEPENDENCY_GRAPH_REPORT_DIR env var will control where the GitHub Dependency Graph Gradle Plugin generates it's reports. The dependency-submission action sets to the <root>/dependency-graph-reports by default.

However, the action implementation currently assumes that the default value is used, and will not locate the generated files if the report dir is set to another location.

We should:

  • Fix the action so that setting DEPENDENCY_GRAPH_REPORT_DIR works for generating and submitting dependency graph files.
  • Possibly add a reports-dir parameter to the action so it's more obvious how to override the report output directory.
@bigdaz bigdaz added bug Something isn't working in:dependency-submission labels Apr 18, 2024
@bigdaz bigdaz self-assigned this Apr 18, 2024
bigdaz added a commit that referenced this issue Apr 18, 2024
If the `DEPENDENCY_GRAPH_REPORT_DIR` var is set, use this value when locating dependency-graph files to upload/submit.

Fixes #188
@bigdaz bigdaz added this to the v3.3.1 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in:dependency-submission
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant