Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache-keys more consistent #131

Merged
merged 4 commits into from Apr 8, 2024
Merged

Make cache-keys more consistent #131

merged 4 commits into from Apr 8, 2024

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Apr 8, 2024

  • All cache keys are now structured as 'gradle--
    • This ensures that extracted entries are prefixed and versioned consistently
  • Avoid using custom cache-key prefix for extracted entries. This should reduce the
    churn in integration tests that require some level of cache isolation.

As a result of this change, cache entries written with previous versions of the action will not be used.

@bigdaz bigdaz self-assigned this Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.7 Build Scan PUBLISHED

Copy link

github-actions bot commented Apr 8, 2024

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.7 Build Scan PUBLISHED

- All cache keys are now structured as 'gradle-<cache-name>-<protocol-version>
  - This ensures that extracted entries are prefixed and versioned consistently
- Avoid using custom cache-key prefix for extracted entries. This should reduce the
  churn in integration tests that require some level of cache isolation.
@bigdaz bigdaz force-pushed the dd/reduce-cache-usage branch 2 times, most recently from 1d09d35 to 59a5222 Compare April 8, 2024 22:49
@bigdaz bigdaz added this to the v3.3 milestone Apr 8, 2024
@bigdaz bigdaz changed the title Reduce cache usage for full-check runs Make cache-keys more consistent Apr 8, 2024
@bigdaz bigdaz merged commit 8ffe734 into main Apr 8, 2024
382 checks passed
@bigdaz bigdaz deleted the dd/reduce-cache-usage branch April 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant