Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dependency-submission from a composite action to a javascript action #116

Closed
bigdaz opened this issue Apr 5, 2024 · 0 comments · Fixed by #124
Closed

Convert dependency-submission from a composite action to a javascript action #116

bigdaz opened this issue Apr 5, 2024 · 0 comments · Fixed by #124
Assignees
@bigdaz
Labels
in:dependency-submission refactor Code improvement with no functional change
Milestone
v3.3

Comments

@bigdaz
Copy link
Member

bigdaz commented Apr 5, 2024

Benefits include:

  • Ability to warn on use of arguments in setup-gradle, but keep using this functionality in dependency-submission
  • Allow dependency-submission step within same workflow Job as setup-gradle
  • Enable uploading dependency-graph immediately for dependency-submission, rather than waiting until end of job
@bigdaz bigdaz added the refactor Code improvement with no functional change label Apr 5, 2024
@bigdaz bigdaz self-assigned this Apr 5, 2024
@bigdaz bigdaz added this to the v3.2 milestone Apr 7, 2024
@bigdaz bigdaz mentioned this issue Apr 7, 2024
Merged
bigdaz added a commit that referenced this issue Apr 7, 2024
@bigdaz
Complete migration of 'dependency-submission' to Typescript (#124)
dbdb67a 
Finishes the migration of `dependency-submission` to a Typescript action
(fixes #116)

- Use consistent input params to ensure behaviour is consistent with
'setup-gradle'
- Submit generated graph immediately instead of waiting until end of job
(fixes #123)
- Can now add a `dependency-submission` step after a `setup-gradle` step
in the same job (fixes #36)
@bigdaz bigdaz modified the milestones: v3.2, v3.3 Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigdaz bigdaz

Labels
in:dependency-submission refactor Code improvement with no functional change
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

Complete migration of 'dependency-submission' to Typescript gradle/actions
1 participant
@bigdaz