Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Canvas3D/Canvas3DGS async imports #7511

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Feb 22, 2024

Description

Closes: #7484

The main fix is 041eb99.
903c81d is a refactoring commit.

In d2ee5df, the undo buttons are disabled in the Gaussian Splatting mode as it's not implemented.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 22, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ece91c97d0e98863f0431d9e09f1f3e4ea47a75f/gradio-4.19.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ece91c97d0e98863f0431d9e09f1f3e4ea47a75f#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 22, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/model3d patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Canvas3D/Canvas3DGS async imports

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx changed the title Fix canvas 3d async imports Fix Canvas3D/Canvas3DGS async imports Feb 22, 2024
@whitphx whitphx marked this pull request as ready for review February 22, 2024 12:21
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of this @whitphx!

@whitphx whitphx merged commit 33f68cb into main Feb 22, 2024
8 checks passed
@whitphx whitphx deleted the fix-canvas-3d-async-imports branch February 22, 2024 13:28
@pngwn pngwn mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model3D] reset button doesn't work
3 participants