Skip to content

Commit 5d98550

Browse files
hannahblairgradio-pr-bot
andauthoredOct 9, 2024··
Fix retry and undo reactivity in gr.Chatbot (#9614)
* fix reactive params * add changeset * fix type check * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
1 parent f57b985 commit 5d98550

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed
 

‎.changeset/puny-lines-do.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@gradio/chatbot": minor
3+
"@gradio/dataframe": minor
4+
"gradio": minor
5+
---
6+
7+
feat:Fix `retry` and `undo` reactivity in gr.Chatbot

‎js/chatbot/shared/ButtonPanel.svelte

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
export let message: NormalisedMessage | NormalisedMessage[];
1818
export let position: "right" | "left";
1919
export let avatar: FileData | null;
20-
export let disable: boolean;
20+
export let generating: boolean;
2121
2222
export let handle_action: (selected: string | null) => void;
2323
export let layout: "bubble" | "panel";
@@ -69,14 +69,14 @@
6969
<IconButton
7070
Icon={Retry}
7171
on:click={() => handle_action("retry")}
72-
disabled={disable}
72+
disabled={generating}
7373
/>
7474
{/if}
7575
{#if show_undo}
7676
<IconButton
7777
Icon={Undo}
7878
on:click={() => handle_action("undo")}
79-
disabled={disable}
79+
disabled={generating}
8080
/>
8181
{/if}
8282
{#if likeable}

‎js/chatbot/shared/Message.svelte

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
likeable: boolean;
7777
show_retry: boolean;
7878
show_undo: boolean;
79-
disable: boolean;
79+
generating: boolean;
8080
show_copy_button: boolean;
8181
message: NormalisedMessage[] | NormalisedMessage;
8282
position: "left" | "right";
@@ -91,7 +91,7 @@
9191
likeable: show_like,
9292
show_retry,
9393
show_undo,
94-
disable: generating,
94+
generating,
9595
show_copy_button,
9696
message: msg_format === "tuples" ? messages[0] : messages,
9797
position: role === "user" ? "right" : "left",

‎js/dataframe/shared/Table.svelte

-2
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,6 @@
991991
{i18n}
992992
x={active_cell_menu.x}
993993
y={active_cell_menu.y}
994-
col={active_cell_menu.col}
995994
row={active_cell_menu?.row ?? -1}
996995
on_add_row_above={() => add_row_at(active_cell_menu?.row ?? -1, "above")}
997996
on_add_row_below={() => add_row_at(active_cell_menu?.row ?? -1, "below")}
@@ -1005,7 +1004,6 @@
10051004
{i18n}
10061005
x={active_header_menu.x}
10071006
y={active_header_menu.y}
1008-
col={active_header_menu.col}
10091007
row={-1}
10101008
on_add_column_left={() => add_col_at(active_header_menu?.col ?? -1, "left")}
10111009
on_add_column_right={() =>

0 commit comments

Comments
 (0)
Please sign in to comment.