Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only export subtle from node:crypto #114

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: only export subtle from node:crypto #114

merged 1 commit into from
Mar 17, 2025

Conversation

lpanni
Copy link
Contributor

@lpanni lpanni commented Mar 14, 2025

only exports the actually called function. Enables bun support.

only exports the actually called function. Enables bun support.
@gr2m gr2m changed the title Be more specific when exporting node:crypto fix: only export subtle from node:crypto Mar 14, 2025
@gr2m
Copy link
Owner

gr2m commented Mar 14, 2025

I'm nervous this might break node, did you check? Does bun support an explicit import map name like we do for node?
Would bun work with crypto-native.js?

"node": "./lib/crypto-node.js",
"default": "./lib/crypto-native.js"

@lpanni
Copy link
Contributor Author

lpanni commented Mar 17, 2025

I'm nervous this might break node, did you check?

The tests still pass.
This should not break anything as no other methods from node:crypto are used anywhere.

Does bun support an explicit import map name like we do for node?

I'm not aware of bun supporting this.

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, cheers!

@gr2m gr2m merged commit 3b0c552 into gr2m:main Mar 17, 2025
3 checks passed
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lpanni lpanni deleted the patch-1 branch March 18, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants