Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use wgsl-native syntax highlighting #4004

Closed
dneto0 opened this issue Mar 25, 2023 · 1 comment · Fixed by #4146
Closed

use wgsl-native syntax highlighting #4004

dneto0 opened this issue Mar 25, 2023 · 1 comment · Fixed by #4146
Labels
copyediting Pure editorial stuff (copyediting, bikeshed, etc.) wgsl WebGPU Shading Language Issues
Milestone
Milestone 0

Comments

@dneto0
Copy link
Contributor

dneto0 commented Mar 25, 2023

Currently the WGSL spec uses rust-based syntax highlighting. But we should use a WGSL specific highlighter.

Bikeshed uses pygments for syntax highlighting.
I've written a pygments lexer. See pygments/pygments#2386
Once that is merged, then we should be able to update all the examples in the WSGL spec.
@dneto0 dneto0 added wgsl WebGPU Shading Language Issues copyediting Pure editorial stuff (copyediting, bikeshed, etc.) labels Mar 25, 2023
@dneto0 dneto0 added this to the V1.0 milestone Mar 25, 2023
@dneto0
Copy link
Contributor Author

dneto0 commented Apr 19, 2023

Pygments 2.15.0 has the WGSL syntax highlighting.

I posted speced/bikeshed#2530 to update Bikeshed with Pygments 2.15.1

dneto0 added a commit to dneto0/gpuweb that referenced this issue May 29, 2023
@dneto0
Use wgsl syntax highlighting
f30382c 
Requires bikeshed 3.11.23, from April 28

Fixes: gpuweb#4004
@dneto0 dneto0 mentioned this issue May 29, 2023
Merged
dneto0 added a commit to dneto0/gpuweb that referenced this issue May 29, 2023
@dneto0
Use wgsl syntax highlighting
54d3a74 
Requires bikeshed 3.11.23, from April 28

Fixes: gpuweb#4004
@dneto0 dneto0 closed this as completed in d9c36d2 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
copyediting Pure editorial stuff (copyediting, bikeshed, etc.) wgsl WebGPU Shading Language Issues
Projects
None yet
Milestone
Milestone 0
Development

Successfully merging a pull request may close this issue.

Use wgsl syntax highlighting dneto0/gpuweb
1 participant
@dneto0