Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assert and golden packages compatible with other golden packages #271

Merged
merged 1 commit into from Jul 30, 2023

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Jul 14, 2023

Fixes #270

Lookup the update flag, and only define it when it's not defined by another package. This works as long as gotest.tools/v3 is imported after the other package. Other packages can make themselves compatible with gotest.tools/v3 by using the same approach.

@dnephin dnephin merged commit e15fa27 into gotestyourself:main Jul 30, 2023
6 checks passed
@dnephin dnephin deleted the gate-update-flag branch July 30, 2023 17:18
kodiakhq bot pushed a commit to cloudquery/plugin-pb-go that referenced this pull request Mar 1, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [gotest.tools/v3](https://togithub.com/gotestyourself/gotest.tools) | indirect | patch | `v3.5.0` -> `v3.5.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>gotestyourself/gotest.tools (gotest.tools/v3)</summary>

### [`v3.5.1`](https://togithub.com/gotestyourself/gotest.tools/releases/tag/v3.5.1)

[Compare Source](https://togithub.com/gotestyourself/gotest.tools/compare/v3.5.0...v3.5.1)

#### What's Changed

-   Make assert and golden packages compatible with other golden packages by [@&#8203;dnephin](https://togithub.com/dnephin) in [gotestyourself/gotest.tools#271
-   Also remove cr from file by [@&#8203;filintod](https://togithub.com/filintod) in [gotestyourself/gotest.tools#273
-   fs: add go doc links by [@&#8203;dolmen](https://togithub.com/dolmen) in [gotestyourself/gotest.tools#275

#### New Contributors

-   [@&#8203;filintod](https://togithub.com/filintod) made their first contribution in [gotestyourself/gotest.tools#273

**Full Changelog**: gotestyourself/gotest.tools@v3.5.0...v3.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package defines -update flag even if golden package is unused
1 participant