New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmarshal: fix panic from reading beyond slice #441
unmarshal: fix panic from reading beyond slice #441
Conversation
Would you mind adding the example problem slice as a new unit test? |
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late approve, was sick last weeks.
No worries, hope you're feeling better. |
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413 * [BUGFIX] Refactor security logger #422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425 * [BUGFIX] unmarshal: fix panic from reading beyond slice #441 Signed-off-by: SuperQ <superq@gmail.com>
Resolves #440
Expand the bounds check of the
packet
bytes to prevent reading beyond the available number of bytes