Fix SendTrap to allow v1 traps that have no varbinds (like coldStart) #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull @damienstuart. Could you please add DCO as mentioned here Pending above this pull request LGTM as rfc1157 4.1.6 mentions that the significance of the variable-bindings component of the Trap-PDU is implementation-specific for SNMP v1. @SuperQ could you please share your thoughts on this? |
Signed-off-by: Damien Stuart <dstuart@dstuart.org>
damienstuart
force-pushed
the
sendTrapFix
branch
from
0a0310d
to
66e7504
Compare
TimRots
approved these changes
Feb 2, 2023
SuperQ
added a commit
that referenced
this pull request
Aug 28, 2023
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413 * [BUGFIX] Refactor security logger #422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425 * [BUGFIX] unmarshal: fix panic from reading beyond slice #441 Signed-off-by: SuperQ <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sending v1 traps that have no varbinds. The check for at least 1 pdu, and the TimeTick check on trap.Variables[0] should apply only to v2c/v3.