Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3_usm.go: add privacy passphrase in extendKeyBlumenthal cacheKey call #425

Merged
merged 1 commit into from Jan 23, 2023

Conversation

TimRots
Copy link
Member

@TimRots TimRots commented Jan 20, 2023

alter extendKeyBlumenthal() function to include the privacy passphrase for cacheKey() calls, to prevent the privacy passphrase that was used for the first connection to be incorrectly reused in any later connections.

fixes #424

Signed-off-by: Tim Rots tim.rots@protonmail.ch

alter  ``extendKeyBlumenthal()`` function to include the privacy
passphrase for cacheKey calls to prevent the privacy passphrase
that was used for the first connection to be incorrectly reused
in any later connections.

fixes gosnmp#424

Signed-off-by: Tim Rots <tim.rots@protonmail.ch>
@TimRots TimRots requested a review from SuperQ January 20, 2023 17:18
@TimRots
Copy link
Member Author

TimRots commented Jan 20, 2023

I also experienced the issue reported in #424 while working on pull 399 , tried to slip-in this fix with that PR which never landed due to an issue with net-snmp dependency for the actual reference testing.

@TimRots TimRots merged commit 9d67d21 into gosnmp:master Jan 23, 2023
SuperQ added a commit that referenced this pull request Aug 28, 2023
This release now requires Go 1.20 or higher.

* [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426
* [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413
* [BUGFIX] Refactor security logger #422
* [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425
* [BUGFIX] unmarshal: fix panic from reading beyond slice #441

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes a previous privacy passphrase is reused instead of the specified one
2 participants