Refactor security logger #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/security-log
branch
2 times, most recently
from
3adb1e6
to
f2ab7d6
Compare
TimRots
approved these changes
Dec 15, 2022
SuperQ
force-pushed
the
superq/security-log
branch
5 times, most recently
from
2f729f9
to
556591f
Compare
|
Weird, the codeql didn't like it when I named the method |
SuperQ
force-pushed
the
superq/security-log
branch
3 times, most recently
from
c08c583
to
490db55
Compare
Customize security logger to avoid logging secret values. * Add a new safe string printers. * Only log the safe strings. * Add some new type string generators. * Bump codeql[0]. [0]: https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/ Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/security-log
branch
from
490db55
to
e2b77a3
Compare
|
Ok, this finally works correctly, please re-review. |
SuperQ
added a commit
that referenced
this pull request
Aug 28, 2023
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413 * [BUGFIX] Refactor security logger #422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425 * [BUGFIX] unmarshal: fix panic from reading beyond slice #441 Signed-off-by: SuperQ <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customize security logger to avoid logging secret values.
Signed-off-by: SuperQ superq@gmail.com