fix:getBulk SnmpPacket can not get right MaxRepetitions value #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yonwoo9 <yonwoo9@gmail.com>
yonwoo9
changed the title
SuperQ
reviewed
Oct 5, 2022
SuperQ
approved these changes
Oct 5, 2022
TimRots
approved these changes
Oct 5, 2022
kajtzu
added a commit
to basen/gosnmp
that referenced
this pull request
Oct 13, 2022
bug:getBulk SnmpPacket can not get right MaxRepetitions value (gosnmp#413)
SuperQ
added a commit
that referenced
this pull request
Aug 28, 2023
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413 * [BUGFIX] Refactor security logger #422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425 * [BUGFIX] unmarshal: fix panic from reading beyond slice #441 Signed-off-by: SuperQ <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unmarshal getBulk SnmpPacket ,can not get right MaxRepetitions value
when call parseRawField() , the packet Asn1BER type is Integer, then it will call parseInt() to parse MaxRepetitions. the parseInt() only return int type, but in marshal.go assert it as uint32,so you will get 0