Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go versions used in CI #792

Closed
garyburd opened this issue Jun 19, 2022 · 3 comments · Fixed by #793
Closed

Update Go versions used in CI #792

garyburd opened this issue Jun 19, 2022 · 3 comments · Fixed by #793
Labels

Comments

@garyburd
Copy link
Contributor

garyburd commented Jun 19, 2022

  • Remove < 1.13 and possibly < 1.16
  • Add 1.18

The current CircleCi config fails when Go 1.18 is added.

See related

I do not have time to work on this. It will be great if somebody else can investigate.

@garyburd
Copy link
Contributor Author

We can move from Circle Ci to something else.

@ChannyClaus
Copy link
Contributor

Oh oops, I just got the PR ready for a review where I added 1.18 for Circle CI - can prepare another that moves the CI off Circle CI if that's preferred.

@amustaque97
Copy link

amustaque97 commented Jun 20, 2022

Oh oops, I just got the PR ready for a review where I added 1.18 for Circle CI - can prepare another that moves the CI off Circle CI if that's preferred.

Initially, I was in favor of moving from Circle CI to Github Actions. I went through a couple of blogs and links. I think we are doing okay with Circle CI.

Here are the links to articles I went through:

  1. https://medium.com/instrument-stories/using-github-actions-and-circleci-b0a30c0a2608
  2. https://coderonfleek.medium.com/circleci-vs-github-actions-a-software-engineers-perspective-14567e539b9c
  3. https://circleci.com/circleci-versus-github-actions/
  4. https://www.tinystacks.com/blog-post/circleci-vs-github-actions-which-is-better/

I will review PR in some time.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants