[GPT-96] Update go version & add verification/testing tools #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvajagtap
changed the title
|
@coreydaley For this repo, multiple golint & gosec errors were reported, which I have silenced for now, as it would have introduced too many changes in one PR. But, this appears to be something we might need to focus on during the next steps. |
apoorvajagtap
force-pushed
the
GPT-95
branch
2 times, most recently
from
33ce071
to
d61b122
Compare
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage ? 90.93%
=======================================
Files ? 5
Lines ? 353
Branches ? 0
=======================================
Hits ? 321
Misses ? 25
Partials ? 7 |
coreydaley
suggested changes
Jul 25, 2023
Co-authored-by: Corey Daley <cdaley@redhat.com> Signed-off-by: Apoorva Jagtap <35304110+apoorvajagtap@users.noreply.github.com>
coreydaley
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing