Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apk): alpine conventional file name #725

Merged
merged 1 commit into from
Oct 14, 2023
Merged

fix(apk): alpine conventional file name #725

merged 1 commit into from
Oct 14, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 10, 2023

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Oct 10, 2023
@caarlos0 caarlos0 self-assigned this Oct 10, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 19799d2
Status: ✅  Deploy successful!
Preview URL: https://a4848c0d.nfpm.pages.dev
Branch Preview URL: https://apk-name.nfpm.pages.dev

View logs

@caarlos0 caarlos0 mentioned this pull request Oct 10, 2023
2 tasks
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #725 (19799d2) into main (4b4f04a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          10       10           
  Lines        2412     2412           
=======================================
  Hits         1811     1811           
  Misses        425      425           
  Partials      176      176           
Files Coverage Δ
apk/apk.go 73.79% <100.00%> (ø)

@caarlos0 caarlos0 requested a review from a team October 10, 2023 16:46
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit a2d723a into main Oct 14, 2023
41 of 42 checks passed
@caarlos0 caarlos0 deleted the apk-name branch October 14, 2023 21:50
@github-actions github-actions bot added this to the v2.34.0 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerelease version using env
2 participants