Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passphrase environment variable #58

Open
rootulp opened this issue Nov 27, 2023 · 0 comments
Open

Passphrase environment variable #58

rootulp opened this issue Nov 27, 2023 · 0 comments

Comments

@rootulp
Copy link

rootulp commented Nov 27, 2023 •
edited

Context

Thanks for this awesome project! I'm successfully using goreleaser-cross to build binaries for multiple platforms with CGO support. Tangent: our project needs this because it uses hardware wallets (i.e. Ledger) that depend on CGO.

Problem

I'm encountering an issue with signing here. Copy + pasted below for convenience

  ⨯ release failed after 5m16s                       error=sign: gpg failed: exit status 2: gpg: signing failed: Inappropriate ioctl for device
gpg: signing failed: Inappropriate ioctl for device

make: *** [Makefile:183: prebuilt-binary] Error 1
Error: Process completed with exit code 2.

A quick ChatGPT search leads me to believe this is happening because the passphrase hasn't been plumbed through and the process is opening an interactive prompt to ask for the passphrase.

Proposal

Add an environment variable to plumb the passphrase through and provide it during the signing step in Goreleaser
This was referenced Nov 27, 2023
Closed
Merged
rootulp added a commit to celestiaorg/celestia-app that referenced this issue Dec 4, 2023
@rootulp
feat: prebuilt binaries with Ledger support (#2872)
0e94856 
Closes #2729

This PR removes [checksum
signing](https://goreleaser.com/customization/sign/) because
goreleaser/goreleaser-cross#58.

## Testing

The assets on
https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc52

OS | Platform | Ledger support 
--- | --- | ---
Darwin | arm64 | ✅  
Darwin | amd64 | ✅ 
Linux | arm64 | 
Linux | amd64 | ✅
mergify bot pushed a commit to celestiaorg/celestia-app that referenced this issue Dec 4, 2023
@rootulp @mergify
feat: prebuilt binaries with Ledger support (#2872)
ba01a7e 
Closes #2729

This PR removes [checksum
signing](https://goreleaser.com/customization/sign/) because
goreleaser/goreleaser-cross#58.

## Testing

The assets on
https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc52

OS | Platform | Ledger support
--- | --- | ---
Darwin | arm64 | ✅
Darwin | amd64 | ✅
Linux | arm64 |
Linux | amd64 | ✅

(cherry picked from commit 0e94856)

# Conflicts:
#	.github/workflows/ci-release.yml
#	README.md
#	scripts/signing/verify-signature.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp