Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint errors #159

Merged
merged 1 commit into from
Jan 21, 2024
Merged

fix: lint errors #159

merged 1 commit into from
Jan 21, 2024

Conversation

arnested
Copy link
Contributor

@arnested arnested commented Jan 21, 2024

golangci-lint detected a few issues:

format_test.go:53:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
	} else {
		golddata, _ := os.ReadFile(fmt.Sprintf("./testdata/%s", pkg.Name))

		if diff := cmp.Diff(string(golddata), testdata); diff != "" {
			t.Errorf("FormatChangelog mismatch (+got -want):\n%s", diff)
		}
	}
order_test.go:16:2: dot-imports: should not use dot imports (revive)
	. "github.com/smartystreets/goconvey/convey"
	^

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c28f513) 65.18% compared to head (f196d6b) 65.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   65.18%   65.18%           
=======================================
  Files           7        7           
  Lines         247      247           
=======================================
  Hits          161      161           
  Misses         64       64           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djgilcrease djgilcrease merged commit 819eaf2 into goreleaser:main Jan 21, 2024
6 checks passed
@arnested arnested deleted the fix-lint-errors branch January 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants