-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very dangerous log.Fatal called in several places #762
Milestone
Comments
Thank you for the very quick response! Hope it will get merged soon and included in the next release :) |
That's probably an oversight from |
Fixed with #763 |
Great work everyone! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(using v6.0.2)
We are about to use this in production and we noticed that when passing an invalid certificate it panics. This can cause unexpected failures at runtimes, and i saw that #616 was marked as closed but it does not seem to be.
There are three
log.Fatal
in the codebase:config.go
line 325: "Failed to parse certificate"server.go
line 112 and line 151I wonder why the error cannot bubble up to the
NewClient
because that now returns an error.Are we missing something? Thanks in advance
The text was updated successfully, but these errors were encountered: