Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for FindServers and FindServersOnNetwork #675

Merged
merged 5 commits into from Aug 22, 2023
Merged

feat: add support for FindServers and FindServersOnNetwork #675

merged 5 commits into from Aug 22, 2023

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Aug 21, 2023

This PR adds support for FindServers and FindServersOnNetwork

@sruehl
Copy link
Contributor Author

sruehl commented Aug 21, 2023

A note on that: Support was there before by using c.Send, so in a nutshell this PR exposes this functionality top level and adjusting the README

@sruehl
Copy link
Contributor Author

sruehl commented Aug 21, 2023

if this PR is unwanted because this functionality is unwanted (and independent of that) I would suggest adjusting the README to add the highlevel/lowlevel support as columns because at first clance without reading the small disclaimer at the top it seems like gopcua doesn't have discovery services support implemented.

magiconair
magiconair requested changes Aug 21, 2023
View reviewed changes
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
examples/discovery/discovery.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@magiconair
Copy link
Member

if this PR is unwanted because this functionality is unwanted (and independent of that) I would suggest adjusting the README to add the highlevel/lowlevel support as columns because at first clance without reading the small disclaimer at the top it seems like gopcua doesn't have discovery services support implemented.

Let's add this. Thank you.

@sruehl
Copy link
Contributor Author

sruehl commented Aug 21, 2023

if this PR is unwanted because this functionality is unwanted (and independent of that) I would suggest adjusting the README to add the highlevel/lowlevel support as columns because at first clance without reading the small disclaimer at the top it seems like gopcua doesn't have discovery services support implemented.

Let's add this. Thank you.

Ok, should I add it to this PR or a new PR?

@sruehl sruehl force-pushed the feat/FindServers branch 5 times, most recently from 8fcab74 to b1ea946 Compare August 21, 2023 11:44
@sruehl sruehl mentioned this pull request Aug 21, 2023
Merged
@sruehl
Copy link
Contributor Author

sruehl commented Aug 21, 2023

I added the README adjustments to a new PR #676

@sruehl sruehl requested a review from magiconair August 21, 2023 11:59
magiconair
magiconair requested changes Aug 22, 2023
View reviewed changes
client.go Outdated Show resolved Hide resolved
examples/discovery/discovery.go Outdated Show resolved Hide resolved
examples/discovery/discovery.go Outdated Show resolved Hide resolved
@magiconair magiconair added this to the v0.5.1 milestone Aug 22, 2023
@magiconair
Copy link
Member

merged #674 so you can rebase to main

@magiconair
Copy link
Member

I'm making some changes to the GitHub actions. I'll ask you to rebase one more time when I'm done.

@magiconair
Copy link
Member

See #677

@sruehl
Copy link
Contributor Author

sruehl commented Aug 22, 2023

rebased on main after #677 was merged

magiconair
magiconair requested changes Aug 22, 2023
View reviewed changes
examples/discovery/discovery.go Outdated Show resolved Hide resolved
@magiconair magiconair merged commit 8afa891 into gopcua:main Aug 22, 2023
5 checks passed
@sruehl sruehl deleted the feat/FindServers branch August 22, 2023 12:03
@magiconair
Copy link
Member

All done and released v0.5.1. Thank you @sruehl !!! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiconair magiconair magiconair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sruehl @magiconair