Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore include-component-in-tag default (false) #888

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Dec 1, 2023

v3 had this option and must be configurable or at least set to false so that the default behavior is to create a plain v1.2.3 tag (without the component name prefixed).

Found this while dogfooding our own usage of the action (in this repo).

@chingor13 chingor13 merged commit 19431a1 into main Dec 1, 2023
2 checks passed
@chingor13 chingor13 deleted the dev/component-defautl branch December 1, 2023 19:37
chingor13 added a commit that referenced this pull request Dec 1, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.0.0](google-github-actions/release-please-action@v3.7.13...v4.0.0)
(2023-12-01)


### ⚠ BREAKING CHANGES

* remove most configuration options in favor of manifest configuration
to configure the release-please-action
* rewrite in typescript
* remove command option in favor of setting `release-type` and
`skip-github-release`/`skip-github-pull-request`
* run on node20
* **deps:** upgrade release-please to v16
* v4 release

### Features

* **deps:** upgrade release-please to v16
([9cf05a0](google-github-actions/release-please-action@9cf05a0))
* remove command option in favor of setting `release-type` and
`skip-github-release`/`skip-github-pull-request`
([9cf05a0](google-github-actions/release-please-action@9cf05a0))
* remove most configuration options in favor of manifest configuration
to configure the release-please-action
([9cf05a0](google-github-actions/release-please-action@9cf05a0))
* run on node20
([9cf05a0](google-github-actions/release-please-action@9cf05a0))
* v4 release
([9cf05a0](google-github-actions/release-please-action@9cf05a0))


### Bug Fixes

* bump release-please from 16.3.0 to 16.3.1
([#876](https://github.com/google-github-actions/release-please-action/issues/876))
([c9291a9](google-github-actions/release-please-action@c9291a9))
* restore include-component-in-tag default (false)
([#888](https://github.com/google-github-actions/release-please-action/issues/888))
([19431a1](google-github-actions/release-please-action@19431a1))


### Code Refactoring

* rewrite in typescript
([9cf05a0](google-github-actions/release-please-action@9cf05a0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants