feat: set 'version' of composer.json in RootComposerUpdatePackages #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
chingor13
requested changes
Jan 26, 2024
Comment on lines
+34
to
+39
| if (parsed['version']) { | ||
| const fromVersion: string = parsed['version']; | ||
| const toVersion = this.version.toString() || '1.0.0'; | ||
| parsed['version'] = toVersion; | ||
| logger.info(`updating "version" from ${fromVersion} to ${toVersion}`); | ||
| } |
There was a problem hiding this comment.
Can you add tests for setting this root version entry (with the value set and unset)?
There was a problem hiding this comment.
I believe this is the kind of test you're looking for? 5093438
chingor13
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2198
Marked as a
featsince it changes the behavior ofRootComposerUpdatePackageby always updatingversionincomposer.json.IMPORTANT: The behavior of the php strategy (
src/strategies/php.ts) will not change, asversionwas already being set in theversionsMap. The only difference in the php strategy is in the case wherecomposer.jsonincludes areplacesection: the "version" key will no longer be added to it. This is the desired behavior, as adding such a string toreplaceresults in a composer exception.