Skip to content

Commit 4d20a8e

Browse files
committedDec 11, 2024
Fix: Remove deprecated text_mode argument (#1379)
1 parent 58b5040 commit 4d20a8e

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed
 

‎google/cloud/storage/fileio.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,6 @@ class BlobWriter(io.BufferedIOBase):
237237
writes must be exactly a multiple of 256KiB as with other resumable
238238
uploads. The default is the chunk_size of the blob, or 40 MiB.
239239
240-
:type text_mode: bool
241-
:param text_mode:
242-
(Deprecated) A synonym for ignore_flush. For backwards-compatibility,
243-
if True, sets ignore_flush to True. Use ignore_flush instead. This
244-
parameter will be removed in a future release.
245-
246240
:type ignore_flush: bool
247241
:param ignore_flush:
248242
Makes flush() do nothing instead of raise an error. flush() without
@@ -296,7 +290,6 @@ def __init__(
296290
self,
297291
blob,
298292
chunk_size=None,
299-
text_mode=False,
300293
ignore_flush=False,
301294
retry=DEFAULT_RETRY_IF_GENERATION_SPECIFIED,
302295
**upload_kwargs,
@@ -312,8 +305,7 @@ def __init__(
312305
# Resumable uploads require a chunk size of a multiple of 256KiB.
313306
# self._chunk_size must not be changed after the upload is initiated.
314307
self._chunk_size = chunk_size or blob.chunk_size or DEFAULT_CHUNK_SIZE
315-
# text_mode is a deprecated synonym for ignore_flush
316-
self._ignore_flush = ignore_flush or text_mode
308+
self._ignore_flush = ignore_flush
317309
self._retry = retry
318310
self._upload_kwargs = upload_kwargs
319311

‎tests/unit/test_fileio.py

-7
Original file line numberDiff line numberDiff line change
@@ -326,13 +326,6 @@ def test_attributes_explicit(self):
326326
self.assertEqual(writer._chunk_size, 512 * 1024)
327327
self.assertEqual(writer._retry, DEFAULT_RETRY)
328328

329-
def test_deprecated_text_mode_attribute(self):
330-
blob = mock.Mock()
331-
blob.chunk_size = 256 * 1024
332-
writer = self._make_blob_writer(blob, text_mode=True)
333-
self.assertTrue(writer._ignore_flush)
334-
writer.flush() # This should do nothing and not raise an error.
335-
336329
def test_reject_wrong_chunk_size(self):
337330
blob = mock.Mock()
338331
blob.chunk_size = 123

0 commit comments

Comments
 (0)
Please sign in to comment.