fix: adding property setter for table constraints, #1990

[lkhagvadorj-amp]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1990 🦕

---

Overview

This pull request introduces enhancements to the google/cloud/bigquery/table.py file by adding setter methods and conversion functions. Additionally, a new unit test is added to ensure the functionality of the new setter method.

Enhancements to google/cloud/bigquery/table.py:

• Added a setter method for table_constraints to allow setting primary key and foreign key information.
• Added to_api_repr method to the ForeignKey class to return a dictionary representation of the object.
• Added to_api_repr method to the TableConstraints class to return a dictionary representation of the object.

Unit tests:

• Added a test for the table_constraints property setter to ensure it correctly updates the table properties.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Linchin]

Thank you @lkhagvadorj-amp for making the contribution! The PR looks great, but could you do the following things so we can merge it:

1. sign the CLA because it's part of the legal requirements
2. add some unit tests: unit tests for both to_api_repr() methods, and more test cases for the setter, for 100% test coverage
3. add a system test for this property

Thanks again and happy holidays!

[lkhagvadorj-amp]

@Linchin
Hi

Happy to contribute and thank you for the initial review!

I’ve pushed the testing changes—would be grateful if you could review them again.

Happy holidays!

[Linchin]

Thank you @lkhagvadorj-amp, I ran the test again, but it seems we need to fix several tests. I'm sorry that I have to trigger the presubmit tests manually, but you can run the system test locally by pytest tests/system/test_client.py, the lint test by nox -s lint, and mypy_samples test by nox -s mypy_samples. (You can install nox by pip install nox.)

[jmesterh]

Is this PR dead? Constraints are required for BigQuery CDC to function.

[lkhagvadorj-amp]

@jmesterh
Thank you for reminder.

I will work on this change on this weekend.
My apologies for late fixing. :)

[lkhagvadorj-amp]

@Linchin
Hi , hope you're doing well! 👋

Could you please take another look at my PR when you get a chance?
Sorry about the many commits—I'll make sure to keep it cleaner next time. Thanks so much for your time! 🙏

[Linchin]

I think we need to add a test case for this case

[lkhagvadorj-amp]

added more test on eq under unit test

[Linchin]

Hi @lkhagvadorj-amp thanks for updating the PR, from the tests it seems we need some additional test coverage, and need to fix linting. Could you update the PR so we can pass these tests?

We are in the process of migrating our testing infra so there's a confusingly large number of tests that are failing, but for now the only ones that matter are "Kokoro" and "Kokoro linting-typing", and you can ignore the rest.

[Linchin]

Thanks @lkhagvadorj-amp, there's still a test failing in linting, could you fix it too? Here's the message:

nox > mypy -p google --show-traceback
google/cloud/bigquery/table.py:3473: error: Incompatible types in assignment (expression has type "List[Dict[str, Any]]", target has type "Dict[str, List[str]]")  [assignment]

[lkhagvadorj-amp]

@Linchin
Hi thank you!
Fixed on linting error (mypy check).

Please let me know if you have any additional comments.

[Linchin]

LGTM, thank you for your contribution!

[lkhagvadorj-amp]

@Linchin
Yeaay!

My apologies for too many commits and looping again and again.

Happy to contribute!