Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: two fixit fixes #2050

Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore: two fixit fixes #2050

merged 2 commits into from
Nov 1, 2024

Conversation

leahecole
Copy link
Contributor

fixes b/376678489 and b/372030525

@leahecole leahecole requested review from a team as code owners October 31, 2024 17:56
@leahecole leahecole requested a review from Linchin October 31, 2024 17:56
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 31, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 31, 2024
@chalmerlowe
Copy link
Collaborator

The python library typing_extensions dropped support for Python 3.7 in a PR issued 9 months ago (v4.8). We have a corresponding PR hardcoding into our requirements.txt to use v4.7.1 if we need to install Python 3.7.

Having said that, it appears as though the install may not be respecting our wishes as defined in the requirements.txt file.

The line of code that gives an error in the logs includes a keyword argument (closed) that was NOT introduced to the typing_extensions library until v4.9.

File "/workspace/samples/desktopapp/.nox/py-3-7/lib/python3.7/site-packages/pip/_vendor/typing_extensions.py", line 1039
    def TypedDict(typename, fields=_marker, /, *, total=True, closed=False, **kwargs):

Add support for PEP 7xx. (support added in version 4.9, Feb 8, 2024)

python/typing_extensions@b7bf949

Drop support for Python 3.7 (support dropped in 4.8, Jul 6, 2023)

python/typing_extensions@8860c6a

@leahecole
Copy link
Contributor Author

Tony let me know that the owlbot PR I just merged should fix this, so I'll merge main in and see if it's true!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2024
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole merged commit fef8b88 into main Nov 1, 2024
20 checks passed
@leahecole leahecole deleted the fix_docs branch November 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants