fix: Improve Any decode error
#712
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was:
TypeError: Could not convert Any to PredictLongRunningResponse
Now:
TypeError: Could not convert
Any[google.ai.generativelanguage.v1main.PredictLongRunningResponse] to
google.ai.generativelanguage.v1beta.PredictLongRunningResponse
|
@MarkDaoust Hmm looking at your comment above, is this right syntax |
ohmayr
reviewed
Oct 4, 2024
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: s
ohmayr
approved these changes
Oct 21, 2024
tests/unit/test_protobuf_helpers.py
Outdated
| with pytest.raises( | ||
| TypeError, | ||
| match=re.escape( | ||
| "Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`" |
There was a problem hiding this comment.
Am I reading this correct or should it instead be the following? (My assumption is that the underlying type should be Any).
Suggested change
| "Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`" | |
| "Could not convert `google.type.Date` with underlying type `google.protobuf.any_pb2.Any` to `google.type.TimeOfDay`" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was (useless):
Now:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
from_any_pbgives a useless error message when the type names don't match. #711Fixes #711 🦕