Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand types of custom metadata within FileMetadata #2442

Merged
merged 1 commit into from Apr 18, 2024
Merged

fix: expand types of custom metadata within FileMetadata #2442

merged 1 commit into from Apr 18, 2024
+1 −1

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2441 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners April 18, 2024 18:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 18, 2024
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2024
@ddelgrosso1 ddelgrosso1 merged commit 1d434a9 into googleapis:main Apr 18, 2024
16 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix-metadata-types branch April 18, 2024 20:07
@release-please release-please bot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileMetadata type missing null on metadata for delete
2 participants
@ddelgrosso1 @danielbankhead