feat: add header for deno runtime for metrics tracking #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ddelgrosso1
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
the
api: storage
ruyadorno
reviewed
Jun 20, 2023
Co-authored-by: Ruy Adorno <ruyadorno@google.com>
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
sofisl
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
danielbankhead
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
lgtm, we can discuss Deno types support later https://deno.land/manual@v1.35.1/advanced/typescript/configuration#targeting-deno-and-the-browser
Comment on lines
+175
to
+193
| export function getRuntimeTrackingString(): string { | ||
| if ( | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| globalThis.Deno && | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| globalThis.Deno.version && | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| globalThis.Deno.version.deno | ||
| ) { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| return `gl-deno/${globalThis.Deno.version.deno}`; | ||
| } else { | ||
| return `gl-node/${process.versions.node}`; | ||
| } | ||
| } |
There was a problem hiding this comment.
This would be a good candidate for a centralized JS-environment utility
| if ( | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| globalThis.Deno && |
There was a problem hiding this comment.
Should we add Deno types? https://deno.land/manual@v1.35.1/advanced/typescript/configuration#targeting-deno-and-the-browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃