Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Print runtime env for integration tests #1865

Merged
merged 6 commits into from Jul 25, 2023
Merged

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jul 24, 2023

No description provided.

@wu-hui wu-hui requested review from a team as code owners July 24, 2023 15:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 24, 2023
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/node12/system-test-against-test-db.cfg - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 24, 2023
@wu-hui wu-hui changed the title Print runtime env for integration tests Chore: Print runtime env for integration tests Jul 24, 2023
2
)}`
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for adding the logging.

@wu-hui wu-hui merged commit edbc9b1 into main Jul 25, 2023
14 checks passed
@wu-hui wu-hui deleted the wuandy/RuntimeEnv branch July 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants