Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolving issues with multi-DB support #1864

Merged
merged 2 commits into from Jul 20, 2023
Merged

fix: Resolving issues with multi-DB support #1864

merged 2 commits into from Jul 20, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@MarkDuckworth MarkDuckworth requested review from a team as code owners July 20, 2023 14:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 20, 2023
@MarkDuckworth MarkDuckworth changed the title Markduckworth/named db fixes fix: Resolving issues with multi-DB support Jul 20, 2023
@tom-andersen tom-andersen merged commit 1af49c1 into main Jul 20, 2023
14 checks passed
@tom-andersen tom-andersen deleted the markduckworth/named-db-fixes branch July 20, 2023 14:57
@release-please release-please bot mentioned this pull request Jun 9, 2023
Merged
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Jul 20, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@ehsannas ehsannas

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarkDuckworth @tom-andersen @ehsannas