fix: Updated logging in the client pool and client factory to log information about the required transport and actual transport used. #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion about the required transport and actual transport used.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: firestore
ehsannas
approved these changes
May 30, 2023
| null, | ||
| 'Initialized Firestore GAPIC Client (useFallback: %s)', | ||
| useFallback | ||
| ); |
There was a problem hiding this comment.
not part of this PR, but the 575 above
const useFallback = !this._settings.preferRest || requiresGrpc ? false : 'rest';is... not great. Took me a second to wrap my head around it, partly because the logic is negated IMO. I think writing it this way makes more sense:
const useFallback = this._settings.preferRest && !requiresGrpc ? 'rest' : false;
|
Also, conventionalcommits bot is failing. Need to update the PR title. |
MarkDuckworth
changed the title
MarkDuckworth
added
the
automerge
gcf-merge-on-green
bot
deleted the
markduckworth/client-pool-transport-logging
branch
gcf-merge-on-green
bot
removed
the
automerge
gcf-owl-bot bot
added a commit
that referenced
this pull request
Sep 12, 2023
Revert "fix: update sample directory link (#1853)" This reverts commit 270f3abf028c63ba3668380329ff532c1c21ed93. Source-Link: googleapis/synthtool@a9808dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:2feb2cd10b64d2b1623f7c6353aa87449e46aa1548024c657c3baf974d37cf38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.