Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

chore: de-duplicating region tag #220

Merged
merged 5 commits into from
Aug 10, 2023
Merged

chore: de-duplicating region tag #220

merged 5 commits into from
Aug 10, 2023

Conversation

meredithslota
Copy link
Contributor

Addressing a region tag conflict with the other nodejs-firestore quickstart sample.

Unverified

The email in this signature doesn’t match the committer email.
@meredithslota meredithslota requested a review from a team as a code owner November 9, 2022 00:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 9, 2022
@snippet-bot
Copy link

snippet-bot bot commented Nov 9, 2022

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sorry, something went wrong.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore-session API. label Nov 9, 2022
@meredithslota
Copy link
Contributor Author

Note that SnippetBot is referring to this page (https://cloud.google.com/firestore/docs/samples/firestore-quickstart#firestore_quickstart-nodejs) which is actually the incorrect sample to be included there, and the rationale for de-duplicating this region tag. Sample Browser will automatically pick up the correct sample once the region tag is unique.

meredithslota and others added 2 commits August 8, 2023 16:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 8, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/publish.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool

@sofisl sofisl merged commit 996d2c2 into main Aug 10, 2023
@sofisl sofisl deleted the normalize-region-tags branch August 10, 2023 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore Issues related to the googleapis/nodejs-firestore-session API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants