Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Content-Range header is formatted with default locale #2972

Closed
nicktindall opened this issue Mar 5, 2025 · 0 comments · Fixed by #2974 or #2965
Closed

Storage: Content-Range header is formatted with default locale #2972

nicktindall opened this issue Mar 5, 2025 · 0 comments · Fixed by #2974 or #2965
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nicktindall
Copy link

nicktindall commented Mar 5, 2025 •
edited
Loading

Environment details

OS type and version: Mac OS X/15.3.1/aarch64
3. Java version: Oracle Corporation/OpenJDK 64-Bit Server VM/23/23+37-2369
4. version(s): 2.48.2

Steps to reproduce

  1. Run Java with locale that uses non-english number characters (e.g. ps)
  2. Execute a resumable upload

Any additional information below

The range header is generated formatting the numbers using the default locale. So for ps we get

bytes ۰-۹۲۱۷۳۷۵/۹۲۱۷۳۷۶ when it should be bytes 0-9217376/9217376

See examples of the issue

It seems it could be resolved by using %s instead of %d perhaps?
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Mar 5, 2025
@nicktindall nicktindall changed the title Storage: Range header is formatted with default locale Storage: Content-Range header is formatted with default locale Mar 5, 2025
@nicktindall nicktindall mentioned this issue Mar 5, 2025
Merged
BenWhitehead added a commit that referenced this issue Mar 5, 2025
@BenWhitehead
fix: update usages of String.format to explicitly pass Locale.US
6835471 
Usage of `Storage#format(String, Object...)` will use the default locale for it's formatting. This can lead to unexpected formatting if a right-to-left language such as Arabic is the default locale.

Update all usages to use `String.format(Locale.US, pattern, Object...)` so we ensure things like headers or error messages are formatted according to the US conventions which match `en_US` and ascii byte conventions.

Incidentally, things like right-to-left formatting seem to only apply to java11+ not java8.

Fixes #2972
BenWhitehead added a commit that referenced this issue Mar 5, 2025
@BenWhitehead
fix: update usages of String.format to explicitly pass Locale.US
Loading
Loading status checks…
79da949 
Usage of `Storage#format(String, Object...)` will use the default locale for it's formatting. This can lead to unexpected formatting if a right-to-left language such as Arabic is the default locale.

Update all usages to use `String.format(Locale.US, pattern, Object...)` so we ensure things like headers or error messages are formatted according to the US conventions which match `en_US` and ascii byte conventions.

Incidentally, things like right-to-left formatting seem to only apply to java11+ not java8.

Fixes #2972
@BenWhitehead BenWhitehead mentioned this issue Mar 5, 2025
Merged
@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 5, 2025
@release-please release-please bot mentioned this issue Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@nicktindall @BenWhitehead