Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package-info with gRPC GA Allowlist #2430

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Feb 29, 2024

Update google-cloud-storage package-info to include information on gRPC API in java-storage per product team request.

Borrowed some from: googleapis/google-cloud-cpp#13688

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Feb 29, 2024
@frankyn frankyn requested a review from danielduhh February 29, 2024 20:11
@frankyn
Copy link
Contributor Author

frankyn commented Feb 29, 2024

Getting hit with unmanaged dependency error here as well @JesseLovelace

@frankyn frankyn marked this pull request as ready for review February 29, 2024 20:11
@frankyn frankyn requested a review from a team as a code owner February 29, 2024 20:11
@sydney-munro
Copy link
Contributor

Getting hit with unmanaged dependency error here as well @JesseLovelace

@suztomo are we aware of this issue?

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 29, 2024
@frankyn frankyn requested a review from a team as a code owner March 4, 2024 21:43
* <p>At present, GCS gRPC is GA with Allowlist. To access this API, kindly contact the Google Cloud
* Storage gRPC team at gcs-grpc-contact@google.com with a list of GCS buckets you would like to
* Allowlist. Please note that while the **service** is GA (with Allowlist), the client library
* features remain experimental and subject to change without notice. The methods to create, list,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bug to remember to remove this once we declare GA in the libs

@frankyn frankyn merged commit 0b5f11a into main Mar 4, 2024
22 checks passed
@frankyn frankyn deleted the update-grpc-with-allowlist branch March 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants