feat(large-row-skip): added large-row-skip-callable with configurable rowadapter #2509
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
justinuang
reviewed
Mar 11, 2025
| @@ -1361,6 +1361,43 @@ public <RowT> ServerStreamingCallable<Query, RowT> readRowsCallable(RowAdapter<R | |||
| return stub.createReadRowsCallable(rowAdapter); | |||
| } | |||
|
|
|||
| /** | |||
| * Streams back the results of the query. This callable allows for customization of the logical | |||
There was a problem hiding this comment.
Mention that this skips large rows
justinuang
approved these changes
Mar 11, 2025
andre-sampaio
approved these changes
Mar 11, 2025
| @@ -1361,6 +1361,43 @@ public <RowT> ServerStreamingCallable<Query, RowT> readRowsCallable(RowAdapter<R | |||
| return stub.createReadRowsCallable(rowAdapter); | |||
| } | |||
|
|
|||
| /** | |||
| * Streams back the results of the query skipping the large-rows. This callable allows for customization of the logical | |||
| * representation of a row. It's meant for advanced use cases. | |||
There was a problem hiding this comment.
I know we already have the InternalApi decorator, but can we also make it explicit on the method docs that this is an internal API, it is subject to breaking changes and should not be relied on by user code?
Just want to make sure this is very explicit for now
andre-sampaio
added
the
kokoro:run
|
/gcbrun |
|
Ah also please make sure the conventionalcommits check passes (I suspect it may just be missing a space after |
yoshi-kokoro
removed
the
kokoro:run
|
feat: is present in the first commit |
You should be able to just change the title of the PR, that's the message that we will use when we squash + merge |
|
/gcbrun |
|
it already contains feat: what needs to be changed? |
The message on the check isn't being super clear, but I think you need a space after
instead of
|
|
or even better:
|
andre-sampaio
changed the title
andre-sampaio
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
🤖 I have created a release *beep* *boop* --- ## [2.55.0](https://togithub.com/googleapis/java-bigtable/compare/v2.54.0...v2.55.0) (2025-03-11) ### Features * Add MaterializedViewName to ReadRows and SampleRowKeys ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * Add MaterializedViews and LogicalViews APIs ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * Add MaterializedViews and LogicalViews APIs ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) * Add PrepareQuery api and update ExecuteQuery to support it ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * **bigtable:** Add support for data APIs for materialized views ([#2508](https://togithub.com/googleapis/java-bigtable/issues/2508)) ([6310a63](https://togithub.com/googleapis/java-bigtable/commit/6310a631be3345f97d73b50f3b458fe40b071286)) * **large-row-skip:** Added large-row-skip-callable with configurable rowadapter ([#2509](https://togithub.com/googleapis/java-bigtable/issues/2509)) ([ba193ef](https://togithub.com/googleapis/java-bigtable/commit/ba193ef771f913e6e6a1aca630fe52d0921ee077)) * Next release from main branch is 2.55.0 ([#2506](https://togithub.com/googleapis/java-bigtable/issues/2506)) ([4e45837](https://togithub.com/googleapis/java-bigtable/commit/4e458378cc25a4dc5ac3fd1362626d89f0138186)) * Publish row_key_schema fields in table proto and relevant admin APIs to setup a table with a row_key_schema ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.54.0 ([91e4369](https://togithub.com/googleapis/java-bigtable/commit/91e4369d280c09fd2d1b4b5dd88809b6da01b0f8)) ### Documentation * Fixed formatting of resource path strings ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
andre-sampaio
pushed a commit
that referenced
this pull request
Mar 19, 2025
… rowadapter (#2509) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
andre-sampaio
pushed a commit
that referenced
this pull request
Mar 19, 2025
🤖 I have created a release *beep* *boop* --- ## [2.55.0](https://togithub.com/googleapis/java-bigtable/compare/v2.54.0...v2.55.0) (2025-03-11) ### Features * Add MaterializedViewName to ReadRows and SampleRowKeys ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * Add MaterializedViews and LogicalViews APIs ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * Add MaterializedViews and LogicalViews APIs ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) * Add PrepareQuery api and update ExecuteQuery to support it ([1763c6e](https://togithub.com/googleapis/java-bigtable/commit/1763c6e9304010ed4034e1ddd03fdb94bca615dc)) * **bigtable:** Add support for data APIs for materialized views ([#2508](https://togithub.com/googleapis/java-bigtable/issues/2508)) ([6310a63](https://togithub.com/googleapis/java-bigtable/commit/6310a631be3345f97d73b50f3b458fe40b071286)) * **large-row-skip:** Added large-row-skip-callable with configurable rowadapter ([#2509](https://togithub.com/googleapis/java-bigtable/issues/2509)) ([ba193ef](https://togithub.com/googleapis/java-bigtable/commit/ba193ef771f913e6e6a1aca630fe52d0921ee077)) * Next release from main branch is 2.55.0 ([#2506](https://togithub.com/googleapis/java-bigtable/issues/2506)) ([4e45837](https://togithub.com/googleapis/java-bigtable/commit/4e458378cc25a4dc5ac3fd1362626d89f0138186)) * Publish row_key_schema fields in table proto and relevant admin APIs to setup a table with a row_key_schema ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.54.0 ([91e4369](https://togithub.com/googleapis/java-bigtable/commit/91e4369d280c09fd2d1b4b5dd88809b6da01b0f8)) ### Documentation * Fixed formatting of resource path strings ([7340527](https://togithub.com/googleapis/java-bigtable/commit/73405272c3fc77ca81c1df7cce1b8d889d4a96c4)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.