Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pubsub): remove duplicate ctx assignment in ordered keys test #9476

Merged
merged 2 commits into from Feb 27, 2024

Conversation

hongalex
Copy link
Member

ctx was being rewritten but read by previous goroutine. Assignment to new context fixes the warning.

Fixes #9474 #9475

@hongalex hongalex requested review from shollyman and a team as code owners February 27, 2024 02:02
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the Pub/Sub API. labels Feb 27, 2024
@hongalex hongalex enabled auto-merge (squash) February 27, 2024 18:19
@hongalex hongalex merged commit 2ac1bcc into googleapis:main Feb 27, 2024
9 checks passed
@hongalex hongalex deleted the fix-pubsub-ordering-race-condition branch February 27, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: TestIntegration_OrderingWithExactlyOnce failed
2 participants