Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): support kinesis ingestion admin #9458

Merged
merged 6 commits into from Mar 7, 2024

Conversation

hongalex
Copy link
Member

Exposes Kinesis ingestion topics admin feature, as added in this commit

Internal tracking issue: 325126943

@hongalex hongalex requested review from shollyman and a team as code owners February 23, 2024 00:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the Pub/Sub API. labels Feb 23, 2024
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Outdated Show resolved Hide resolved
@hongalex hongalex added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 27, 2024
@hongalex hongalex removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 7, 2024
@hongalex hongalex enabled auto-merge (squash) March 7, 2024 19:08
@hongalex hongalex merged commit 9bba269 into googleapis:main Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants