Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): add WithREST option to vertexai client #9389

Merged
merged 8 commits into from Feb 8, 2024

Conversation

eliben
Copy link
Contributor

@eliben eliben commented Feb 8, 2024

Initially configure whether the client uses REST or gRPC

@eliben eliben requested review from a team as code owners February 8, 2024 13:57
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 8, 2024
vertexai/genai/client.go Outdated Show resolved Hide resolved
vertexai/genai/clientconfig.go Outdated Show resolved Hide resolved
vertexai/genai/clientconfig.go Outdated Show resolved Hide resolved
vertexai/genai/clientconfig.go Outdated Show resolved Hide resolved
@eliben eliben requested a review from jba February 8, 2024 14:38
@eliben eliben changed the title feat(vertexai): add NewClientWithConfig constructor feat(vertexai): add WithUseREST option to vertexai client Feb 8, 2024
vertexai/genai/client_test.go Show resolved Hide resolved
vertexai/genai/option.go Outdated Show resolved Hide resolved
vertexai/genai/option.go Outdated Show resolved Hide resolved
@eliben eliben requested a review from jba February 8, 2024 19:26
@eliben eliben changed the title feat(vertexai): add WithUseREST option to vertexai client feat(vertexai): add WithREST option to vertexai client Feb 8, 2024
@eliben eliben added the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit f5d56eb into googleapis:main Feb 8, 2024
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants