Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Return error in correct format from test proxy #9233

Merged

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 8, 2024

Before fix:

=== RUN   TestReadModifyWriteRow_NoRetry_TransientError
    test_workflow.go:133: The RPC to test proxy encountered error: rpc error: code = Unavailable desc = ReadModifyWriteRow failed
    readmodifywriterow_test.go:278: 
        	Error Trace:	cloud-bigtable-clients-test/tests/readmodifywriterow_test.go:278
        	Error:      	Should NOT be empty, but was <nil>
        	Test:       	TestReadModifyWriteRow_NoRetry_TransientError
    readmodifywriterow_test.go:279: 
        	Error Trace:	cloud-bigtable-clients-test/tests/readmodifywriterow_test.go:279
        	Error:      	Not equal: 
        	            	expected: 14
        	            	actual  : 0
        	Test:       	TestReadModifyWriteRow_NoRetry_TransientError
--- FAIL: TestReadModifyWriteRow_NoRetry_TransientError (0.01s)
FAIL
exit status 1
FAIL	github.com/googleapis/cloud-bigtable-clients-test/tests	0.345s

After fix i.e. returning error in status field of result instead of separate variable:

=== RUN   TestReadModifyWriteRow_NoRetry_TransientError
--- PASS: TestReadModifyWriteRow_NoRetry_TransientError (0.01s)
PASS
ok  	github.com/googleapis/cloud-bigtable-clients-test/tests	1.260s

@bhshkh bhshkh requested review from a team as code owners January 8, 2024 20:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the Bigtable API. labels Jan 8, 2024
@bcoe bcoe requested review from a team and removed request for a team January 11, 2024 21:34
@bhshkh bhshkh enabled auto-merge (squash) January 16, 2024 20:42
@bhshkh bhshkh disabled auto-merge January 16, 2024 20:42
@bhshkh bhshkh enabled auto-merge (squash) January 16, 2024 20:42
@bhshkh bhshkh merged commit 8deb9ab into googleapis:main Jan 16, 2024
9 of 12 checks passed
@bhshkh bhshkh deleted the test/cbt-conf-test-read-modify-write-row-1 branch January 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants