feat(storage): add maxAttempts RetryOption #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Jan 4, 2024
codyoss
changed the title
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
ecdd447
to
7af9602
Compare
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
1582407
to
fbb30ff
Compare
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
ff5f087
to
c154295
Compare
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
ae12811
to
03aa6fe
Compare
product-auto-label
bot
added
the
api: storage
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Jan 5, 2024
This seems to have been missed in an earlier update and now presubmits are failing on googleapis#9215
tritone
reviewed
Jan 5, 2024
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
b20899c
to
17890c9
Compare
Tulsishah
force-pushed
the
configure_max_retry_count
branch
from
27e4d50
to
ca327a0
Compare
tritone
added
the
kokoro:force-run
product-auto-label
bot
added
size: l
Tulsishah
changed the title
tritone
reviewed
Jan 15, 2024
product-auto-label
bot
added
size: m
tritone
approved these changes
Jan 17, 2024
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: By specifying a count limit for retries using max-retry-count, we can ensure that applications stop automatically retrying operations after that count. This allows you to proactively detect and investigate any persistent issues, rather than letting applications keep attempting to retry indefinitely. This can be particularly beneficial for troubleshooting purposes, as it helps pinpoint the root cause of the failure more quickly.
Adding to configure max retry count in RetryOption to the storage package.
Testing details
Manual - NA
Unit tests - Added
Integration tests - NA