Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add trace span to Writer #8375

Merged
merged 3 commits into from Aug 3, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Aug 2, 2023

Adds a trace span that covers a Writer from open to close. Nested spans already cover individual requests / RPCs that the Writer makes.

Fixes #6144

Adds a trace span that covers a Writer from open to close.
Nested spans already cover individual RPCs that the Writer
makes.

Fixes googleapis#6144
@tritone tritone requested review from a team as code owners August 2, 2023 21:58
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Aug 2, 2023
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f7ac85b into googleapis:main Aug 3, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2023
@tritone tritone deleted the trace-writer branch August 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: create a span for NewWriter
2 participants