Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix AllObjects condition in gRPC #8184

Merged
merged 3 commits into from Jun 29, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jun 28, 2023

Fixes incorrect handling of zero values for the AgeDays field of bucket lifecycle conditions. Allows re-enabling the integration test for bucket create/delete for gRPC.

Fixes #6205

Fixes incorrect handling of zero values for the AgeDays field of
bucket lifecycle conditions. Allows re-enabling the integration test
for bucket create/delete for gRPC.

Fixes googleapis#6205
@tritone tritone requested review from a team as code owners June 28, 2023 23:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jun 28, 2023
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2b99e4f into googleapis:main Jun 29, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2023
@tritone tritone deleted the lifecycle-zero-fix branch July 5, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: determine if zero values are automatically set for OLM rules for gRPC
2 participants