Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): rename host variable used for xml reads #8160

Merged
merged 3 commits into from Jun 27, 2023
Merged

chore(storage): rename host variable used for xml reads #8160

merged 3 commits into from Jun 27, 2023

Conversation

BrennaEpp
Copy link
Contributor

Since reads no longer only use XML, readHost is misleading as it is used only for XML reads.

@BrennaEpp BrennaEpp requested review from a team as code owners June 21, 2023 04:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Jun 21, 2023
@BrennaEpp BrennaEpp mentioned this pull request Jun 21, 2023
Merged
@BrennaEpp BrennaEpp enabled auto-merge (squash) June 27, 2023 01:03
@BrennaEpp BrennaEpp merged commit cf3452e into googleapis:main Jun 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrennaEpp @tritone