Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Same method name and Trace Span name #8150

Merged

Conversation

sinmetal
Copy link
Contributor

I think the method name and the Trace Span Name are expected to be the same, so I fixed that.

@sinmetal sinmetal requested review from a team as code owners June 19, 2023 03:05
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 19, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Jun 19, 2023
@sinmetal sinmetal force-pushed the storage/fix-trace-span-name branch from 35f2a28 to 55b8a88 Compare June 19, 2023 03:08
@sinmetal sinmetal changed the title fix(storage): fixed Method name and Trace Span name being different fix(storage): Same method name and Trace Span name Jun 19, 2023
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jul 19, 2023
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2023
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and sorry to miss this one earlier.

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Aug 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e277213 into googleapis:main Aug 1, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small. stale: old Pull request is old and needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants