fix(firestore): do not trace iterator.Done error #8082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include
err
in the"cloud.google.com/go/firestore.Query.RunQuery"
trace if it isiterator.Done
.Since the return values are named for
queryDocumentIterator.next()
, even areturn
statement with concrete values will set those named return variables to the values returned. This means a line likereturn nil, iterator.Done
actually setserr
toiterator.Done
.Fixes #7711