fix(datastore): Handling nil slices in save and query #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
approved these changes
Jun 6, 2023
bhshkh
changed the title
kolea2
approved these changes
Jun 12, 2023
bhshkh
added a commit
to bhshkh/google-cloud-go
that referenced
this pull request
Jun 13, 2023
…apis#8043)" This reverts commit 36f01e9.
bhshkh
added a commit
that referenced
this pull request
Jun 13, 2023
xwkuang5
pushed a commit
to xwkuang5/google-cloud-go
that referenced
this pull request
Jun 13, 2023
…nto agg-add-trace * 'agg-add-trace' of github.com:xwkuang5/google-cloud-go: Fix formating. chore(firestore): Add bloom filter related comments (googleapis#8079) fix(firestore): Cleanup integration test resources (googleapis#8057) fix(datastore): Handling nil slices in save and query (googleapis#8043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5760
Cause:
If an entity e.g. {'Description': 'Buy milk'} is being queried into a struct e.g.
task := Task{Description: "Some description", Done: false, Slice: []int{11, 12, 13, 14, 15}}, then the fields not existing in entity retrieved from datastore are left untouched i.e.it.Next(&task)will populate task variable toTask{Description: "Buy milk", Done: false, Slice: []int{11, 12, 13, 14, 15}}Any nil slice property in put call to datastore gets ignored i.e. as if the property does not exist for that entity. So, while retrieving nil slices, they don't get populated in the struct.
Fix: Write nil slices as null values to datastore similar to nodejs and python client libraries. Special handling for nil slices while querying datastore.