Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix reads with "./" in object name [XML] #8017

Merged
merged 4 commits into from Jun 1, 2023

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented May 31, 2023

Previously, XML reads failed when the object had "./" in the name. This fixes the encoding for such a case.

Fixes #7236

Previously, XML reads failed when the object had "./" in the name. This fixes the encoding for such a case.
@BrennaEpp BrennaEpp requested review from a team as code owners May 31, 2023 02:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels May 31, 2023
@BrennaEpp BrennaEpp changed the title fix(storage): fix reads with "./" in object names [XML] fix(storage): fix reads with "./" in object name [XML] May 31, 2023
@BrennaEpp BrennaEpp requested a review from tritone June 1, 2023 17:52
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@BrennaEpp BrennaEpp merged commit 6b7b21f into googleapis:main Jun 1, 2023
8 checks passed
@BrennaEpp BrennaEpp deleted the fix-xml-obj-name branch June 1, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: ErrObjectNotExist in NewRangeReader for "./" prefixed objects
2 participants