Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): WithXMLReads should mention XML instead of JSON API #7881

Merged

Conversation

v0lkc
Copy link
Contributor

@v0lkc v0lkc commented May 4, 2023

I've spotted a copy/paste issue in the description of storage.WithXMLReads. It states it would use the JSON API instead of XML, which is obviously wrong.

@v0lkc v0lkc requested review from a team as code owners May 4, 2023 09:29
@google-cla
Copy link

google-cla bot commented May 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels May 4, 2023
@BrennaEpp BrennaEpp added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 4, 2023
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing and opening a PR!

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 36f56c8 into googleapis:main May 4, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants