Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): fix progress call in gRPC Writer #7872

Merged
merged 2 commits into from May 3, 2023
Merged

chore(storage): fix progress call in gRPC Writer #7872

merged 2 commits into from May 3, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented May 2, 2023 •
edited

Fixes #7839

@tritone tritone requested review from a team as code owners May 2, 2023 19:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels May 2, 2023
BrennaEpp
BrennaEpp approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just note that this fixes #7839 not #7798

@tritone
Copy link
Contributor Author

tritone commented May 3, 2023

Looks good, just note that this fixes #7839 not #7798

Whoops, good catch

@tritone tritone enabled auto-merge (squash) May 3, 2023 13:27
@tritone tritone merged commit aa8810d into googleapis:main May 3, 2023
8 checks passed
@tritone tritone deleted the write-progress branch May 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennaEpp BrennaEpp BrennaEpp approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: Writer.ProgressFunc is always called at least once [GRPC]
2 participants
@tritone @BrennaEpp